Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fromArray(): Always ensure _originalData is available #48

Merged
merged 1 commit into from May 26, 2015
Merged

fromArray(): Always ensure _originalData is available #48

merged 1 commit into from May 26, 2015

Conversation

nicjansma
Copy link
Contributor

Otherwise this statement:

if ((this._originalData && !this._originalData[colName]) || this.isNew()) {
    this._originalData[colName] = data[colName];
}

Might try to set a value on this._originalData when it doesn't exist if this.isNew()

xavierlacot added a commit that referenced this pull request May 26, 2015
@xavierlacot
Merge pull request #48 from nicjansma/master
3964d8f 
fromArray(): Always ensure _originalData is available
@xavierlacot xavierlacot merged commit 3964d8f into xavierlacot:master May 26, 2015
@xavierlacot
Copy link
Owner

thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nicjansma @xavierlacot