Added group_by function. #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -621,7 +625,17 @@ joli.query.prototype = { | |||
|
|
|||
| this.data.where += expression + ' IN ' + value; | |||
| return this; | |||
| }, | |||
|
|
|||
| group_by: function(group) { | |||
There was a problem hiding this comment.
It would be better to write a groupBy() method instead of the underscored group_by(). Apart of it, the patch is perfect, thanks a lot !
There was a problem hiding this comment.
You're right, I am doing too much ruby these days ;) will fix it and do another pull request!
ghost
closed this
|
didn't know how to edit the existing branch on github, solved it by opening another ;) |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was missing a GROUP BY, so I've added it.
Hope you'll pull it in ;)