New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jslint errors #7
Comments
Hi Matthew, joli.js is compatible with the jshint.com validation, but not with the JSLint one, which is slightly more strict. I am not sure if it is really useful to conform to JSLint, and the changes proposed by JSLint will help a lot, but go ahead if you feel so, and I'll merge your changes if they do not have any impact on the code's performance. Thanks a lot, |
Hey Xavier. |
Woops Xavier, just read your email and seen your last commit, and it seems you have included a solution where the U in CRUD is possible. I see you've also fixed a few of the issues with JSLint compatibility. I'll try out this version now, and if it works I'll fork and create a JSLint compatible version which you can incorporate if you wish. Thanks for the U update, greatly appreciated. |
You're welcome :) cheers, Xavier On Tue, Jul 12, 2011 at 10:37 AM, mattheworiordan <
Xavier Lacot |
Hi Xavier
Love your library, thanks.
One small issue I have when using Joli is that the Javascript does not pass the JSLint set of tests, whereas all my other code does. I realise this is not necessarily an error, but it is advisable to conform to JSLint generally. Here are the errors that come up with JSLint and Joli.js http://www.pastie.org/2196158
Would you be willing to make the necessary changes? If not, would you be willing to merge in the changes if I go ahead and do that?
The text was updated successfully, but these errors were encountered: